Add support for example option passed through env variable
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jraoult! No worries about the tests for now. I'll release a new version soon. |
|
9.1.0 is now released. Also added support for setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to set the
exampleoption using an env variable. As rightly pointed out here in this issue,DOTENV_CONFIG_PATHis supported thanks todotenv, but since it is not aware ofdotenv-safe'sexampleoption this one is ignored.I added the support for
DOTENV_CONFIG_EXAMPLEindotenv-safe/config.js. I got inspiration from what is done indotenv/config.jsbeing more restrictive than my initial patch and only explicitly supportingDOTENV_CONFIG_EXAMPLEconfig.jsis not covered by the current test suite so I'm unsure how to proceed. The manual way of testing is typically the following command:It would fail before with
Error: ENOENT: no such file or directory, open '.env.example'but is now supported.closes #126 (comment)